BuddyPress.org

I’m attempting to point out how this is becoming a rather confused issue and gain clarification for all concerned

Is the issue that you ARE disabling the admin bar for anonymous, non logged in users but doing so leaves a blank space?

What is your definition of a ‘Guest User’ normally ‘Guest’ and Anonymous are one and the same thing and refer to someone browsing your site without being logged in.

After updating to buddypress 1.2.6 from 1.2.5.2 , my site does not show admin bar for guest user(as admin is disabled for loggedout users) , instead inplace it shows a white space …

Logged in users can view the admin bar correctly , but non-loggedin users or guest users cannot see the admin bar , instead of the admin bar there is a white space in place … !!!

What I don’t understand is why CAN I see the admin bar when I visit your site?

As this is a custom theme have you actually tried asking the wpmu guys for support? as per my suggestion on the other thread.

As I presume the other thread is finished with and my snippet of code of no use I will close that thread as it only serves to confuse if it runs on.

@AnindyaRay: Hmmm what happens just as a ‘test’ with the default BuddyPress theme and your site? I always use the BuddyPress default theme as my ‘baseline’ test.

@anindyaray I still don’t really get what your actual issue is looking at your site as a logged out /anonymous user shows the adminbar but beside that , and obviously as you state above, you are using a custom theme so no my fix won’t work for you I and most of the others can only provide solutions based on default BP theme or core actions we or this forum can’t really support custom themes especially premium custom themes you must take issue with those themes to the original authors.

However the padding in you case is on the body so perhaps you need to revise the code I wrote for you and substitute ‘body’ for ‘#header’ and see if that works?

@AnindyaRay : Well I get a JavaScript error on your page when testing with firebug and that certainly could be making your adminbar get grumpy. My advice would be to using firebug track down what is causing that by turning off all plugins and widgets and extra code you’ve added then adding it in one by one. I usually opt for the ‘all off’ dramatic approach myself as saves time building up as oppose to one by one off. Up to you though.

@Maryke: Depends if your child uses the default BuddyPress one and has any core / major files changes in it. If it’s just CSS or additions to code then probably not but if it’s changes to code you’d have to check for anything that could be different. Generally if using default theme as your parent you’ll at least be 99% ok just depends on how extensive you’ve got in your child which I can’t really say.

@hnla
Thank for your help
I’m using wp 3.0.1 and bp 1.2.6 , with theme named “Blogs-mu”
I’m tried putting the code snippet provided by you in the function.php of the theme file which didn’t worked,
and also tried putting the code in bp-custom.php in plugins directory , which too didn’t helped
actually it happen nothing , no errors also , so it seems to me I’m pasting the code correctly !

@abarro – disablng the 25px top padding from admibar.css will cause some overlapping if the theme header have some thing else at that near top position, but for your case its ok because you have disabled the adminbar completely.

Then you’re doing something wrong! Without actual detail on what you have done or tried to do it leaves it to us to have to makes guesses which generally is wasteful of time and resources.

Rather than simply state it didn’t work describe what you tried to do with the above code, also we have little detail on what setup you are running i.e custom theme etc

So does this mean, if I’m using a child theme, I have to make a lot of changes?

Possibly because there are is a mix of issues, if you referring to the remaining padding-top then that is a property being declared in default.css on the #header ruleset and will be there regardless of the state of the adminbar:

I have only time to suggest a quick fix for that in lieu of a new ticket raised on the overall issue for 1.3

You can try dropping this into a function.php file in a child theme (you will need to add opening php tag as your file structure dictates)
`
function cancel_header_padding_for_no_adminbar() {
if(defined( ‘BP_DISABLE_ADMIN_BAR’ ) || $bp->doing_admin_bar = false) ?>

/**/
<?php
}
add_action( ‘wp_head’, ‘cancel_header_padding_for_no_adminbar’ );
`
It would also probably work in bp-custom.php to ensure it was picked up for all possible bp themes.

Note: I do not suggest this as an answer it’s a hack to get around the issue, but not a good approach all in all

I noticed your lightbox works in buddypress. Mine stopped working for me when I installed buddypress. My flickr photo gallery no longer loads photos in the lighbox… it just get stuck. When I de-activate buddypress, it works again. I tried other themes too – even the buddypress default theme, and that isn’t the problem. Any suggestions?
http://colage.dreamhosters.com/photos/

@AnindyaRay

Have you seen this thread? It looks like there may be a solution to your problem near the end:
https://buddypress.org/community/groups/how-to-and-troubleshooting/forum/topic/buddypress-1-2-6-adds-extra-padding-top/

It is, indeed, a theme issue. You should be able to fix things based on the info here: https://trac.buddypress.org/ticket/2679#comment:1

well, my idea was this:

reading through the forums and the codex I found a couple of settigns that seemingly can be used from wp-config.php BUT I don’t want to clutter it too much.
Alternatively I can use bp-custom.php or make a small plugin and pop it into mu-plugins.

here is my collection of lines, please let me know where I can find more (built-into BP as I know plugins also offer several of these). What is recommended for what? I try to use wp-config.php only for WP related stuff, mu-plugins only for stuff that really needs to be running on every page and functions.php for stuff specific for my theme (and in this case the main page)

`/*add user with ID as group admin, alternatively change to mod*/
define( ‘BP_RESTRICTGROUP_AUTOADD_ADMIN_USER_ID’, 1);
/* disable the admin bar*/
/*define( ‘BP_DISABLE_ADMIN_BAR’, false);*/

/*customize all slugs*/
/*define( ‘BP_ACTIVATION_SLUG’, ‘activate’ );*/
/*define( ‘BP_ACTIVITY_SLUG’, ‘activity’ );*/
/*define( ‘BP_BLOGS_SLUG’, ‘journals’ );*/
/*define( ‘BP_FORUMS_SLUG’, ‘discussions’ );*/
/*define( ‘BP_FRIENDS_SLUG’, ‘peeps’ );*/
/*define( ‘BP_GROUPS_SLUG’, ‘gatherings’ );*/
/*define( ‘BP_MEMBERS_SLUG’, ‘chefs’ );*/
/*define( ‘BP_MESSAGES_SLUG’, ‘messages’ );*/
/*define( ‘BP_REGISTER_SLUG’, ‘register’ );*/
/*define( ‘BP_SEARCH_SLUG’, ‘search’ );*/
/*define( ‘BP_SETTINGS_SLUG’, ‘settings’ );*/
/*define( ‘BP_XPROFILE_SLUG’, ‘info’ );*/

/*customize more stuff*/
/*Put profiles in the root � http://example.org/username/*/
/*define ( ‘BP_ENABLE_ROOT_PROFILES’, true );*/

(btw. since I have decided upon the final theme to use, I guess I will be going via the functions.php route)

/*Change the default tab opened when looking at a user’srofile (default is activity):*/
/*define( ‘BP_DEFAULT_COMPONENT’, ‘profile’ );*/
`
Also if you want yo ucan give some more information about order of invocation?

You can add the login form to one of the columns after

<div id="third-section" class="widget">


login code:

<?php if ( is_user_logged_in() ) : ?>

        <?php do_action( 'bp_before_sidebar_me' ) ?>

        <div id="sidebar-me">
            <a href="<?php echo bp_loggedin_user_domain() ?>">
                <?php bp_loggedin_user_avatar( 'type=thumb&width=40&height=40' ) ?>
            </a>

            <h4><?php echo bp_core_get_userlink( bp_loggedin_user_id() ); ?></h4>
            <a class="button logout" href="<?php echo wp_logout_url( bp_get_root_domain() ) ?>"><?php _e( 'Log Out', 'buddypress' ) ?></a>

            <?php do_action( 'bp_sidebar_me' ) ?>
        </div>

        <?php do_action( 'bp_after_sidebar_me' ) ?>

        <?php if ( function_exists( 'bp_message_get_notices' ) ) : ?>
            <?php bp_message_get_notices(); /* Site wide notices to all users */ ?>
        <?php endif; ?>

    <?php else : ?>

        <?php do_action( 'bp_before_sidebar_login_form' ) ?>

        <p id="login-text">
            <?php _e( 'To start connecting please log in first.', 'buddypress' ) ?>
            <?php if ( bp_get_signup_allowed() ) : ?>
                <?php printf( __( ' You can also <a href="%s" title="Create an account">create an account</a>.', 'buddypress' ), site_url( BP_REGISTER_SLUG . '/' ) ) ?>
            <?php endif; ?>
        </p>

        <form name="login-form" id="sidebar-login-form" class="standard-form" action="<?php echo site_url( 'wp-login.php', 'login_post' ) ?>" method="post">
            <label><?php _e( 'Username', 'buddypress' ) ?><br />
            <input type="text" name="log" id="sidebar-user-login" class="input" value="<?php echo esc_attr(stripslashes($user_login)); ?>" /></label>

            <label><?php _e( 'Password', 'buddypress' ) ?><br />
            <input type="password" name="pwd" id="sidebar-user-pass" class="input" value="" /></label>

            <p class="forgetmenot"><label><input name="rememberme" type="checkbox" id="sidebar-rememberme" value="forever" /> <?php _e( 'Remember Me', 'buddypress' ) ?></label></p>

            <?php do_action( 'bp_sidebar_login_form' ) ?>
            <input type="submit" name="wp-submit" id="sidebar-wp-submit" value="<?php _e('Log In'); ?>" tabindex="100" />
            <input type="hidden" name="testcookie" value="1" />
        </form>

        <?php do_action( 'bp_after_sidebar_login_form' ) ?>

    <?php endif; ?>

    <?php /* Show forum tags on the forums directory */
    if ( BP_FORUMS_SLUG == bp_current_component() && bp_is_directory() ) : ?>
        <div id="forum-directory-tags" class="widget tags">

            <h3 class="widgettitle"><?php _e( 'Forum Topic Tags', 'buddypress' ) ?></h3>
            <?php if ( function_exists('bp_forums_tag_heat_map') ) : ?>
                <div id="tag-text"><?php bp_forums_tag_heat_map(); ?></div>
            <?php endif; ?>
        </div>
    <?php endif; ?>


You should set your slugs in wp-config.php

Comments should be fine in bp-custom.php – there must some error in the way you have the file set up

Ps you are right that functions.php is theme specific, and bp-custom.php is install wide. However there are also order of invocation issues.. They don’t happen at the same place in the initialisation.

For slug and URL mods have a read of the documentation on here

@rogercoathup

Hmmm… OK, so here’s what I’ll do: as I’ve created this, my first, theme based on 1.2.5, I’ll make it available for die-hard 1.2.5 users on my site. But I’ll update the theme to 1.2.6 before shipping it off to the theme repo with a heads-up that a 1.2.5 version is available for download at http://&#8230;

However, I think the advice given by @karmatosed is sound, so I’ll ensure future themes are in sync with latest version of BP.

Thanks guys!

@AnindyaRay: Hmmm you got a link for your site? My thoughts are maybe a javascript error (try in firebug to see that) or something like error in files (did you copy over the adminbar.css and also both javascript files (ajax.php / js)? I certainly don’t get any issues with the default or my themes that don’t use custom admin bars – perhaps the custom admin bar code. Worst case maybe you could remove that feature (hate to suggest that but if it’s causing issues).

@pcwriter: General rule is last supported version is latest with BuddyPress / WordPress or at least that’s the way I work with themes myself. Can’t really speak for others. I myself choose that route as there are generally security and other reasons for upgrades.

@Roger: I get the frustration but to be truthful I’m a theme designer and I don’t have these issues as said before I go with latest version support and I think you will find most do. This is of course a point of debate and maybe not the place for this said debate as a personal choice / company choice depending on your working situation. This happens with every release it gets better and more gets added… WordPress has same problem if you think of what happened around 3.0 for instance.

I do think it’s perhaps a point of note to those of us in themes to get more involved and this is one point I myself have in the past few months realised. We can complain about things and claim them wrong but until we get involved can we be surprised over something getting changed. It’s a project we all can get involved in and perhaps this all should be a call to action rather than a soap box moment which I know myself I’m feeling. BuddyPress themes will I think truly benefit from those of us that work with them getting involved where we can. Please take this in the good nature it’s meant as I’ve also had this realisation.

@pcwriter

No, any new template tags will not be recognised by your 1.2.5.2 installations.

I’m dismayed by the 1.2.5.2 -> 1.2.6 decision making – with users unable to use 1.2.5.2 themes on 1.2.6. You’d expect some new features in a minor subversion upgrade, some additional template tags you could take or leave, but not for the behaviour of key regularly used functions to be changed overnight (e.g. the multiple friend button issue).

It’s been an issue for us with how on earth we can handle existing bespoke client implementations, but you raise another problem for generic theme developers – you’d have to have two versions of your theme.