BuddyPress.org

Okay, phew, it wasn’t as serious as I first thought. This now won’t send an email if the content is empty (which is, apparently, the case when a user is being deleted):

`function pa_send_notification_email( $args ) {
// If current user deletes his/her own activity, do nothing
if (($args[‘user_id’] != bp_loggedin_user_id())) {
$ud = get_userdata($args[‘user_id’]);
$to = $ud->user_email;
// Build the message
if (($to) && ($to != ”)) {
global $wpdb;
$content = $wpdb->get_var( $wpdb->prepare( “SELECT content FROM “.$wpdb->prefix.”bp_activity WHERE id = %d;”, $args[‘id’] ) );
if ($content != ”) {
$subject = ‘Your post has been removed’;
$message = ‘A moderator has removed your post. If you want to know why, please forward this message to the moderation team.
‘;
$message .= ‘Removed content:
‘;

$message .= wpautop( $content );
$message .= ”;

//Send email
wp_mail($to, $subject, $message, ‘content-type: text/html’ );
}
}
}
}
add_action( ‘bp_before_activity_delete’, ‘pa_send_notification_email’);`

Hmm, the situation is not as dire as I thought. I did more testing and it appears that, when I delete a user who as posted multiple times, my function only sends one notification email to the user — but the SQL query is empty (as we might expect). So I think all I need to do is put a check in to see whether the deleted “content” is empty or not, and if it is, don’t send the email.

I’ll keep updating this thread with my findings in case it’s useful to anyone!

Revisiting this thread with a new issue!

My function has been working well, except I’ve recently discovered a small flaw: if an administrator deletes a user, then the user receives an email informing him or her that his activity has been removed for each and every thing he or she has ever posted! For a prolific user, that could be hundreds or thousands of emails. Not good!

This is by virtue of the user-delete process — it appears as though BuddyPress deletes each activity individually, and then WordPress deletes the user account.

For reference, my function is:

`function pa_send_notification_email( $args ) {
// If current user deletes his/her own activity, do nothing
// otherwise construct and send email
if ($args[‘user_id’] != bp_loggedin_user_id()) {
$ud = get_userdata($args[‘user_id’]);
$to = $ud->user_email;
// Build the message
if (($to) && ($to != ”)) {
$subject = ‘Your post has been removed’;
$message = ‘A moderator has removed your post. If you want to know why, please forward this message to the moderation team.
‘;
$message .= ‘Removed content:
‘;
global $wpdb;
$message .= wpautop( $wpdb->get_var( $wpdb->prepare( “SELECT content FROM “.$wpdb->prefix.”bp_activity WHERE id = %d;”, $args[‘id’] ) ) );
$message .= ”;

//Send email
wp_mail($to, $subject, $message, ‘content-type: text/html’ );
}
}
}
add_action( ‘bp_before_activity_delete’, ‘pa_send_notification_email’);`

So what I think I need is an extra check in my function, to make sure we are not about to delete the user. I’ve thought about a secondary function to hook into the `delete_user` action to set a global variable, and then checking for this variable in my `pa_send_notification_email()` function.

But I am not sure how to go about this. Does anyone have any thoughts?

I’m using Buddypress Social from WPMU.

I switched to BP Default and:

– didn’t see the double avatar in the Activity list
– same problem with updating my profile
– same problem trying to create a Group

For the first issue, of confirming a friend, it was a little more complicated. I used Safari which was logged into antoher user account to accept friendship. It worked normally. I then went to the Friends list, and cancelled the friendship. I’m not sure why the friend was still listed there, but I took advantage of that and clicked on the Add Friend button. It loaded a new page that said:

Are you sure you want to do this?

and then a link that said:

Please try again.

which links back to my Friends page, which this time was blank. In any case, the combination of ‘Are you sure…’ and ‘Please try again.’ seems out of place.

I then went to the Members page, and clicked Add Friend again. I then went to the Members page using my admin account (the account I requested friendship of) and it listed the members including the account I requested from – and next to that name it had a button labeled ‘Cancel Friend Request’ which seems backwards. However, I noticed two notifications in the top menu, one which said the user had accepted my friendship request, and another saying the user had requested my friendship. I selected the second one and was taken to the Requests page. I clicked Accept and it seemed to work normally.

Hope that’s all clear…

I did check out some of the “like” plugins, but most of them hadn’t been maintained or didn’t work properly. I was hoping to tailor a core feature to work in a similar, simple way. So far I think what I have done works great, but just need to incorporate notifications.

I still think that it wold be useful if a user was notified when someone favorited their activity.

Well, after being driven almost bonkers, I have solved this — and found what I think is a bug in BuddyPress 1.6.1.

I went with @shanebpx’s great suggestion of using a get_var query:


$content_id = $args['id'];
global $wpdb;
$content = $wpdb->get_var( $wpdb->prepare("SELECT content FROM ".$wpdb->prefix."bp_activity WHERE id = %d;", $content_id ) );
$message .= wpautop($content);


However, I was baffled by the fact that $content kept coming up empty. Until I finally took a look at how BuddyPress was calling do_action( 'bp_before_activity_delete', $args ); in /bp-activity/bp-activity-functions.php:


if ( !$activity_ids_deleted = BP_Activity_Activity::delete( $args ) )
return false;

do_action( 'bp_before_activity_delete', $args );


Yup, it’s apparently doing the bp_before_activity_delete action after BP_Activity_Activity::delete!

I have edited my copy of /bp-activity/bp-activity-functions.php to put the do_action before the deletion.


do_action( 'bp_before_activity_delete', $args );
if ( !$activity_ids_deleted = BP_Activity_Activity::delete( $args ) )
return false;

// Check if the user's latest update has been deleted
if ( empty( $args['user_id'] ) )
$user_id = bp_loggedin_user_id();
else
$user_id = $args['user_id'];


and at last, my email function works!

Now, how do I go about submitting this as a bug…?

I guess the delete button only passes user_id and id to $args…

@shanebpx: Thanks for that suggestion — it’s beautifully simple. Unfortunately, it appear as though $args['content'] is empty? (But there’s definitely content in the test activity I am deleting!)

For debugging, I tried $message .= print_r($args, true);, which gave:

Array
(
[id] => 31
[action] =>
[content] =>
[component] =>
[type] =>
[primary_link] =>
[user_id] => 52
[item_id] =>
[secondary_item_id] =>
[date_recorded] =>
[hide_sitewide] =>
)

I admit I’m a little bewildered as to why all those values appear empty.

Okaaay, the plugin IS working. Does anyone know why an entry in wp_bp_notifications would not be showing up in notifications?

entry in wp_bp_notifications:

User id#3 is creating the comment and user id#4 is not receiving the notification in the top bar. Anyone know why?

Ok, I think I’ve narrowed it down to this function in the plugin. I know that the function that it is hooking into works. Anyone know why this would fail?

Actually, this function is working—it is creating activity items based on blog posts and comments. I found out that it’s my custom plugin that is supposed to hook into this custom post or comment action to create a notification. Here is the plugin. I know no one will even try to tackle this but I have to post this because it’s my only option and I one for due diligence…

@mercime, thank you for your response. We were getting ready to try your suggestion when this happened:

As you know, the registration emails going out from our site were working but then weren’t working. See previous email. Since then, we went into something we never before went into: Membership, Communications and created a test Welcome message. We registered as a new user and wouldn’t you know we received the registration activation email as that new user, the test Welcome message for the new user and the admin new user notification email. Then we deactivated the test Welcome message and went through the process again. It worked! We received two emails now (just like before the mysterious site-rendered email disappearance); the registration activation email as that new user and the admin new user notification email. We then completely deleted the test Welcome message so that the Membership, Communications was the same as before we started and again, we received the same two emails. Whatever did we reactivate?

So, for whatever reason, the emails seem to be working again. However, this is a huge concern to us. This could happen again and we would have no idea why the emails stopped working and why it suddenly reset itself. We have repeatedly read in our research of this matter that WordPress uses PHPMail Sendmail. It has been mentioned more than once that making the emails go SMTP is better and more stable. We are of the belief that this may be the core issue here. Can anyone give input on this and guide us in the right direction? Is there anyone out there that can explain to us what may have happened and is there something we need to hard code so that it doesn’t happen again?

Many thanks for your help and advice.

So from the explanation of both @modemlooper & @mercime the understanding in minimal terms is the following:
Every BP page I drop into my WP child template will override the core file as it does presently. And in order to create my page I simply drop in shortcodes to develop my page.php, then I apply my CSS to style & design my page. Question – are there already shortcodes in place that I can create a page.php with?

Please explain what @r-a-y is saying with using user_nicename. Why would someone want to create a template for a specific user?
`/wp-content/themes/twentytwelve/buddypress/members/single/home-{user_nicename}.php`

and how would you do that without making a huge mess in your template directory?

Also this would explain how to create different templates for different groups?
For instance:
`/wp-content/themes/twentytwelve/buddypress/members/single/home-{group ID = 1}.php`

Is that correct?

Using these files one could create their own fully templated BP site?:
`’activity/index’

‘blogs/index’
‘blogs/create’

‘registration/activate’
‘registration/register’

/* Ignore these
‘forums/single/forum’
‘forums/single/topic’
‘forums/index’
*/

‘members/index’
‘members/single/activity/permalink’
‘members/single/home’
‘members/single/settings/capabilities’
‘members/single/settings/delete-account’
‘members/single/settings/general’
‘members/single/settings/notifications’

‘groups/create’
‘groups/index’
‘groups/single/home’
‘groups/single/plugins’`