BuddyPress.org

This change is not documented nor annouced in the update post on the BP blog.

About this “some minor tweaks to the included theme”, nobody knows what to do,exactly to retrieve or edit this gravatar. Except here in this tread, which will be buried in the next 3 days in the deepness of this forum
I consider this a bit unfair to find such a picture at this strategic place represented by the SWA page without any permission ! This change can also (as already mentionned) compromise some fine tuned template skills. And what to say about breaking long discuted graphical convention ?
I want at minimum have the possibility to change it, like i can do it for my group avatar for ex.

In 2009, we could choose to use wavarar, gravatar or monsterID from within the admin.
Since 1.2.2 or so, Gravatar is gone (silently) from the admin interface. Now he’s back via SWA….

What do we do(and think) tomorrow, if suddenly Gravatar.com send us an advertising icon instead of a graphic abstract as actually ?
What the sense of all those thousands of millions of icons flying around the web ?
Only to have pretty links or to organize some juicy statistics and server consumption ? The non GPL part of the trick i guess….

ok… two solutions:

1. the nasty hacky – adding define (‘BP_DISABLE_ADMIN_BAR’, TRUE) in our theme’s functions.php

Why nasty hacky: well it inserts inline CSS into our footer to hide the adminbar and remove the padding; that’s nastiest enough in itself, but it also uses !important to override anything we actually want to do – even nastier.

2. the cleaner – adding remove_action( ‘init’, ‘bp_core_add_admin_bar_css’); in our theme’s functions.php

That does the job!

Unfortunately, we have to add that in the functions.php of any additional theme we want to use. Let’s get all this presentation stuff in the default theme where it belongs (not in the core)… I’ve said this a lot recently.

It should be in the theme not in core files but it needs to load at ‘init’ ? or does it? is it that it must load before theme loads

follow up – it’s actually being added in the function:

bp_core_add_admin_bar_css()

in bp-core-cssjs.php

I can’t help but think this should be in the default theme, not in the core files.

@chouf1 – yes, I know where the adminbar.css file is. Coda is my friend

The question was, why is adminbar.css being included in other themes (even none child ones) on a multisite network? What’s injecting it, and how do we turn it off.

e.g. My theme doesn’t explicitly link to adminbar.css, here’s the snippet from the header.php:

`

<link rel="stylesheet" type="text/css" media="all" href="” />
<link rel="pingback" href="” />
<?php
if ( is_singular() && get_option( ‘thread_comments’ ) )
wp_enqueue_script( ‘comment-reply’ );

wp_head();
`

No explicit inclusion of adminbar.css!

But, here’s what actually gets rendered in the browser:

`

`

The unwanted link to adminbar.css has been injected.

I assume it must be something in wp-head() doing it – is there a hook to turn it off?

Hi Roger,
the admin bar is constructed in bp-core/bp-core-adminbar.php
the css file for this is in bp-themesbp-default_inccssadminbar.css

notepad++ is my friend

@clojel

You shouldn’t really mod the core files, as they’ll be overwritten if you upgrade. Is there any filter you can hook on to instead as an interim solution?

Certainly though, this should be added to the trac as a potential bug to be looked at.

We have the same problem with child themes in secondary sites – we’ve turned off the admin bar, we don’t have any admin bar css being included in our child theme, but still it pulls in admin bar css code from bp-default and inserts the unwanted padding.

[As an aside: does anyone know where the code is that’s injecting the admin bar css include into the header of child themes? Is it a hook on wp-footer?]

@whitbyglennk
There is no WP ethos of free software for all. With all the licensing discussions going on, most people have completely misunderstood what it was all about. Free (as in the GPL software license) only means that any further development of GPL software has to be published under the same license (if the software is being released) and that, once you have the software, you can do whatever you please with it. Free does not mean, though, that you can get access to this software without paying. It’s perfectly ok to charge for GPL software.

Most developers, who charge for a plugin or premium themes, still give back to the community by answering questions in forums or uploading other plugins and themes to the WP repository. For some plugins 50+ hours have been spent on development. That’s a lot of money and time right there, but people still expect not to pay anything.

I guess we’ll be seeing more and more paid plugins and themes crop up over the next year. It’s not a bad thing, it’ll give users more choice (there usually is a free alternative around somewhere) and if someone buys a plugin/theme, then afterwards you can expect great support, which does not always happen with a free plugin.

Just me 2 cents

bp-default/functions.php:252
define( 'HEADER_IMAGE_HEIGHT', 125 );
and css tweaked accordingly….

Don’t forget to make these change from within a child theme

@hnla – I think I’d class it as a bug, as it breaks child themes on existing sites
… or perhaps just a deprecated / implementation changed without clear warning mistake

Glenn… there is nothing new in charging for premium themes, it’s not a BuddyPress phenomenon… there are hundreds of people selling premium themes for WordPress (e.g. WooThemes, ThemeForest, …), and even more sites that are completely bespoke developments costing many thousands of pounds.

If you don’t like what people are providing you for free, you don’t have to use their work. If you don’t like the price of their paid for work, don’t buy them. You can take the bp-default theme for free and extend it as you want.

As I explained in one of your other threads about availability of themes, BuddyPress is extremely difficult to create distinctive generic themes for – it’s no wonder that some people charge a few pounds for their themes.

Please check over yesterdays threads as this issue has been covered in two threads and you’ll find the answers there. t’s not a bug but you will need to make some changes to your child theme files.

Yes, there is a BuddyPress primary site … where you’d run a BuddyPress specific theme, that lets you view members directories, group directories, member profiles, etc.

If you do all those changes you should be on track but it’s hard to say really until do it on the theme if that makes sense? Just with the CSS changes remember CSS is cascading and some themes use !important to over-ride this. It’s best to just in testing add your new CSS to the last CSS file called to make sure it has a fighting chance (key term in CSS is cascading). Also consider the theme may have it’s own styling different from the default theme even if uses the basic structure of it.

It’s not a question of whether you like it or not, the problem is that it breaks the design of existing sites – because their themes are using bp-default as a ‘much touted future proof’ parent theme.

You expect bug and compatibility fixes in a theme upgrade, not presentation and design changes.

If you’re changing the actual design, you’d expect that in a new theme. Much as you’ll expect WordPress to release 2011, and not simply overwrite 2010 with something different that changes the look of every child theme based on it.

That child theme should be ok with 1.2.6 it’s just a couple page templates.

If everyone’s going to be friends with everyone else, I’d suggest just turning the Friends component off since it won’t be doing anything interesting. Dashboard > BuddyPress > Component Setup

As for groups, you have a few options. If you make all groups public, then everyone will have access to everything. And if you hide all of the “my groups” and “join this group” buttons in the theme, people will never know (or care!) whether they’re a part of groups. They’ll just be auto-joined if they choose to post on the forums. A different method is to modify something like this: https://buddypress.org/community/groups/auto-join-groups/

@djpaul –

Can we happily run the 1.2.5.2 default theme (and children thereof) on the 1.2.6 core? Thereby allowing all our existing child themes to continue to behave the same without any mods at all?

And, as a corollary to this… is there an install option for 1.2.6 that won’t overwrite the 1.2.5.2 theme (other than copying it somewhere pre-install, and then re-instating)?