BuddyPress.org

@prashantvatsh Thanks, I didn’t realize that every user could see the /members page and then if they click to a members profile they see the public and private messaging buttons too.

It seems that every new registration on the site automatically becomes a Buddypress member. So then they can see the membership list and message any other user without being a member of any group.

This isn’t good, easy for manual spammers to register and send PM spam to members.

Duplicate of https://buddypress.org/support/topic/private-message-button-not-working-right/

Closing to avoid forking the discussion.

@louisarthur – Thanks for sending me credentials. I’ve logged into your site to have a look.

As you note in your email, there’s no href attribute on these links. It’s not clear to me how this would be the case, but I can give you a starting point for looking into it yourself. Briefly, the buttons will be built without an href if the button constructing function passes an empty link_href parameter to the BP_Button class. The functions used in the two cases are different:

Message public: https://buddypress.trac.wordpress.org/browser/tags/2.9.2/src/bp-activity/bp-activity-template.php?marks=3090#L3079

Message privé: https://buddypress.trac.wordpress.org/browser/tags/2.9.2/src/bp-messages/bp-messages-template.php?marks=1362#L1360

The logic in each case is different, but since neither is showing up, I’m guessing that one of two things is happening:

1. One of the conditional checks shared between them is failing for some reason: bp_is_my_profile(), is_user_logged_in().

2. Something on your installation – perhaps your theme but probably a plugin (since you said Twenty Seventeen was exhibiting the problem as well) – is filtering both ‘bp_get_send_private_message_link’ and ‘bp_get_send_public_message_link’, and then incorrect returning empty strings.

To test idea #2, you might try – if you can – searching through your codebase for those filter names.

please use forum’s search before asking !
https://buddypress.org/support/search/private+message+button/

For example:

Disable or Hide Private Message Button

Thank you so much for this code! I’ve spent several hours trying to use other people’s code to hide the button and even tried to make my own but nothing worked until I found your code. I just switched it around because I only wanted one particular group to not be able to send messages while the rest can.

Posting in case someone in the future needs the opposite of your code:

add_filter( 'bp_get_send_message_button', function( $array ) {
    if ( pmpro_hasMembershipLevel('NAMEOFPMPLEVEL') ) {
        return '';
    } else {
        return $array;
    }
} );

Also, I am looking for the same code as you to restrict non-paying users from sending private messages. I found a code that looks promising but unfortunately doesn’t work. It sees if the user is logged in and if not redirects them. Then if the person is logged in it checks their role but if they’re not that role they’re supposed to be redirected. But it just breaks my whole site. Any ideas?

function my_function() {

    if ( ! is_user_logged_in() && bp_is_current_component( 'messages' ) ) {
        // Current user is not logged in so don't let them see stuff. In this case, private messages 
        wp_redirect( home_url() );
        exit;
    }
        
    $flag = false;
    // Get current user info.
    $user = wp_get_current_user();

    if ( ! in_array( 'student', $user->roles ) ) {
        // The current member is not a student.
        $flag = true;
    }

    if ( $flag && bp_is_current_component( 'messages' )  ) {
        The currently logged-in member is not a student and is trying to view private messaging. Let's redirect them away.
        wp_redirect( home_url() );
        exit;
    }
}
add_action( 'init', 'my_function' );

This works and hides the button, but I’m curious. Can someone still send a private message to another user when they are “not” friends using URL manipulation or should the _wpnonce stop that?

hi @masoud1111,

all i found was how to hide that button, or remove it.
but not show it only on some profiles

You just need to add some conditionnals.

Try this (in bp-custom.php) and give feed back if it works.

function bpex_private_message_button( $button ) {
$user = bp_loggedin_user_id();

    if ( is_super_admin() ) { 
		return $button;
	}

	if ( !empty( $user->roles ) && is_array( $user->roles ) ) {

		if ( $role == 'subscriber' || $role == 'contributor' || $role == 'author' || $role == 'editor' )  {
			// hide button for these roles
			$button = '';
		}
	}

	// allow the button to appear on admin's profile only
	if ( bp_is_active( 'xprofile' ) && bp_is_user() )  {	
		$user_id = bp_displayed_user_id();	
		// assuming admin's ID is 1
		if ( $user_id == 1 ) {
			return $button;
		}

	}

}
add_filter( 'bp_get_send_message_button', 'bpex_private_message_button', 1 , 1 );

The function is working correctly on my install.

Perhaps you have an issue with quotes, ie after copy/pasting the snippet from a topic where the code whas inserted without using the code button.
Which software do you use to publish bp-custom ?

Copy/paste following and give a try:

function buddydev_hide_members_directory_from_all_except_admin() {

if ( bp_is_members_directory() && ! is_super_admin() ) {
//should we add a message too?
//bp_core_add_message( 'Private page.', 'error' );
bp_core_redirect( site_url('/') );
}
}
add_action( 'bp_template_redirect', 'buddydev_hide_members_directory_from_all_except_admin' );

This topic is titled “Function to hide private message depending of user role”.

and the snippet does that ! Subscribers have no access to the button. So far i remember it is also the default role in WordPress. You change that to your need.

The first condition in the snippet allows some users (by ID) to access the button, whatever their role.

If you want to add other WP roles, you simply copy the 2nd conditionnal if(role=='') and add another role if(role=='mamamouchi") { //do something }.

Or you use only the user ID if you have only a few members allowed to access. I litle understanding of php is of course a + to do that.
You have the basics in the snippet. Now, it’s to you now to make it work for your need.