BuddyPress.org

I had an issue with a client site that the BP team may want to look into, in the event that it is affecting more sites than just mine.

The issue: Running the latest version of BuddyPress (10.2), I had a client site and server that were seeing spikes to 100% CPU and high RAM usage — but only when a logged-in user opened the WordPress media library (/wp-admin/upload.php).

My hosting support first told me it was a plugin error, then I was told it was a theme error. But we were unable to find any evidence of this. I cloned the live site, deactivated all plugins and switched to a default WP theme, and the issue still occurred.

There were no related items in the Apache or Nginx error logs, but the PHP access log fills with lines like this, seemingly for every media file:

(server IP) – [15/Apr/2022:15:57:37 +0000] “GET /index.php?bp-attachment=13109/NorthCrawford-300×225.jpg” 301 0 – 798 14702 0.648 8388608 9.27% 3.09% “/?bp-attachment=13109/NorthCrawford-300×225.jpg”

The solution: This is what I received from my hosting support:

The issue is BuddyPress created htaccess that redirects all wp-content/uploads/bp-attachments/ to ?bp_attachments= URL. The redirects spawn heaps of apache and php-fpm which also cause the issue . They created this sample htaccess found on the directory below

The htaccess has been renamed so, when you load medias, it should no longer reach 100%

The solution was to take the .htaccess file out of the equation by renaming it, which is only a temporary fix. I presume this file would be overwritten upon the next BP update?

If that’s the case, how would I keep this from happening, aside from renaming the offending .htaccess file each time there is a BP update?

Wordpress v. 5.9.3
Buddypress v. 10.2.0
Theme. BuddyX

In Private Messages – the message body part ‘shows’ at the top that you can attach a file or a link,
the link option works, but when you click on the image attachment, it gives a popup that asks for the ‘source’ of the image. It doesn’t open a normal file explorer window to select the image.
Please, how do I FIX this?

I use gravity forms to create a new user from a groups tab and assign them to a group, based on the group that the group admin is adding them from. This was working just fine in BuddyPress version 8.0 but since upgrading to 10 it is no longer working. What am I missing?

/**
 *  Add member form handler. This form is currently located under the Group Information tab
 */
add_action( 'gform_after_submission', 'add_member_gform_handle', 10, 2 );
function add_member_gform_handle( $entry, $form ) {
	if ( $form['title'] === 'Add Member' ) {
		$fields     = $form['fields'];
		$first_name = rgar( $entry, '1' );
		$last_name  = rgar( $entry, '2' );
		$login      = rgar( $entry, '3' );
		$password   = rgar( $entry, '4' );
		$email 	    = rgar( $entry, '5' );
		$group_id   = rgar( $entry, '6' );
		$role       = rgar( $entry, '11' );
		$notification = rgar( $entry, '9.1' );
		$birthdate = rgar( $entry, '10' );

		$userdata = array(
			'user_login' => $login,
			'user_pass' => $password,
		);

		if ( ! empty( $first_name ) ) {
			$userdata['first_name'] = $first_name;
		}
		if ( ! empty( $last_name ) ) {
			$userdata['last_name'] = $last_name;
		}
		if ( ! empty( $email ) ) {
			$userdata['user_email'] = $email;
		}
		if ( ! empty( $role ) ) {
			$userdata['role'] = $role;
		}

		// Create a new user
		$new_user_id = wp_insert_user( $userdata );

		// GFCommon::log_debug( __METHOD__ . '(): form => ' . print_r( $birthdate, true ) );

		if ( ! is_wp_error( $new_user_id ) ) {
			groups_join_group( $group_id, $new_user_id );

			// Make the user displayed as a staff on a clubhouse page
			if ( $role === 'staff' ) {
				$group_ids =  groups_get_user_groups( $new_user_id );
				$group = groups_get_group( array( 'group_id' => $group_ids['groups'][0]) );
				$group_id = $group->id;
				groups_promote_member( $new_user_id, $group_id, 'admin' );
			} else {
				groups_demote_member( $new_user_id, $group_id );
			}

			if ( ! empty( $notification ) ) {
				tml_send_new_user_notifications( $new_user_id, 'both' );
			}

			if ( ! empty( $birthdate ) ) {
				$date = DateTime::createFromFormat('Y-m-d', $birthdate);
				$date = $date->format('Ymd');

				update_field('user_birthdate', $date, 'user_' . $new_user_id);
			}
		}

		// Delete form entry
		// GFAPI::delete_entry( $entry['id'] );
	}
}

/**
 * Add Member form validation
 */
add_filter( "gform_validation_$clubnet_add_member_form_id", 'add_member_form_validation' );
function add_member_form_validation( $validation_result ) {
	$form = $validation_result['form'];
	$login = rgpost( 'input_3' );
	$email = rgpost( 'input_5' );
	$send_notificaton = rgpost( 'input_9_1' );
 
    if ( ! empty( $login ) && get_user_by( 'login', $login ) ) {
        $validation_result['is_valid'] = false;
 
        //finding Field with ID and marking it as failed validation
        foreach( $form['fields'] as &$field ) {
            if ( $field->id == '3' ) {
                $field->failed_validation = true;
                $field->validation_message = 'The user with this login already exists.';
                break;
            }
        } // foreach
    }

	if ( ! empty( $email ) && get_user_by( 'email', $email ) ) {
        $validation_result['is_valid'] = false;
 
        //finding Field with ID and marking it as failed validation
        foreach( $form['fields'] as &$field ) {
            if ( $field->id == '5' ) {
                $field->failed_validation = true;
                $field->validation_message = 'The user with this email already exists.';
                break;
            }
        } // foreach
    }

	// GFCommon::log_debug( 'VALIDATION' . __METHOD__ . '(): form => ' . print_r( 'Empty', true ) );
	// Email is required if we requested to send a email about user's account
	if ( ! empty( $send_notificaton ) && empty( $email ) ) {
		$validation_result['is_valid'] = false;
        //finding Field with ID and marking it as failed validation
        foreach( $form['fields'] as &$field ) {
			if ( $field->id == '5' ) {
                $field->failed_validation = true;
                $field->validation_message = 'Email is required since you requested to send an email.';
                break;
            }
        } // foreach
	}
 
    //Assign modified $form object back to the validation result
    $validation_result['form'] = $form;
    return $validation_result;
}

/**
 * Role field
 */
add_action( 'init', 'clubnet_add_role_field' );
function clubnet_add_role_field( $form ) {
	global $wp_roles;
	global $clubnet_add_member_form_id;

    $all_roles = $wp_roles->roles;
    // $editable_roles = apply_filters('editable_roles', $all_roles);
	// $roles_to_skip = array( 'administrator' );
	$editable_roles = $all_roles;
	$roles_to_display = array( 'mentor', 'member', 'youth_leader', 'alumni', 'staff' );
	$choices = array();

	foreach ( $editable_roles as $role => $role_data ) {
		if ( ! in_array( $role, $roles_to_display ) ) {
			continue;
		}

		$choice = array(
			'text' => $role_data['name'],
			'value' => $role
		);

		array_push( $choices, $choice );
	}

	// Reorder to make member role first
	usort( $choices, function( $choice ) {
		if ( $choice['text'] === 'Member' ) {
			return -1;
		}

		return 1;
	} );

	$form = GFAPI::get_form( $clubnet_add_member_form_id );
	
	if ( ! $form ) {
		return;
	}

	$label = 'User Role';
	$field_idx = -1;
	$field_id = -1;

	foreach ($form['fields'] as $idx => $field) {
		if ( $field->label === $label ) {
			$field_idx = $idx;
			$field_id  = $field->id;
		}
	}

	if ( $field_idx === -1 ) {
		$field_id = GFFormsModel::get_next_field_id( $form['fields'] );
	}

	$props = array( 
		'id' => $field_id,
		'label' => $label,
		'type' => 'select',
		'choices' => $choices,
	); 

	if ( $field_idx === -1 ) {
		$field = GF_Fields::create( $props );
		$form['fields'][] = $field;
		GFAPI::update_form( $form );
	} else if ( $form['fields'][$field_idx]->choices !== $choices ) {
		$field = GF_Fields::create( $props );
		$form['fields'][$field_idx] = $field;
		GFAPI::update_form( $form );
	}
}

Hi!
Trying to find the source of sudden weird lag on my large Buddypress website. I noticed this query running very frequently:

# Time: 220408 21:41:46
# User@Host: [removed] @ localhost []
# Thread_id: 337208  Schema: [removed] QC_hit: No
# Query_time: 1.645619  Lock_time: 0.000068  Rows_sent: 0  Rows_examined: 0
# Rows_affected: 0  Bytes_sent: 77
SET timestamp=1649454106;
SELECT DISTINCT a.id  FROM wp_bp_activity a  WHERE  
( 
	( 
		( 
			a.component = 'groups' 
			AND 
			a.item_id IN ( 0 )
		)
 
		AND 
		a.hide_sitewide = 0
	)

)
 AND a.is_spam = 0 AND a.type NOT IN ('activity_comment', 'last_activity') ORDER BY a.date_recorded DESC, a.id DESC LIMIT 0, 16;

Query_time: 1.645619

It always results in nothing. So, where is it coming from and how can I stop it?
Any idea what function is triggering this, I’d be able to even edit the core file just to have it check “if certain params are true, don’t even run this query”

I think it’s killing my site’s performance

For our intranet, we use BuddyPress extended profiles as well as WPO365 to sync data from Microsoft active directory. We don’t allow users to edit their avatars or user information as everything is synced from Microsoft.

After the last update, our “Recently active users” widget is showing old (and sometimes no) avatar for users. When you click through to the profile however the newer images load correctly.

It almost looks like the avatars stored for BuddyPress are different from the BuddyPress extended profile avatar.

Is there a simple fix for this or do we need to stop using the recently active widget all together?