BuddyPress.org

@shanebp

1- I do understand this, but if you change a filter and use it like that for a while, and then want to change it again, your existing data will stay unchanged. To me the solution is to not have a filter for things that won’t be able to be manipulated later on.

2- Building dynamic strings may be ever so slightly slower, but it’s the reason I love WordPress – To have the power to easily and dynamically change data.

The main reason I want to make changes to the code is because BuddyPress currently provides a specific way to output things, example:

“Author Name posted an update in the group [group avatar] Group Name, 14 hours, 00 minutes ago”

A: None of the links have a class set (except for the time) Meaning that I can’t add CSS to increase the size of “Author Name” without affecting “Group Name” and vice-versa. So I was trying to manipulate the filter to add a class.

B: I want to change the order of the output, for example if I increase the size of the group avatar I would want to move it from where it is completely. Not very flexible for people who want to make the line work/look a certain way.

Another example of this problem is the avatar sizes:

If you define the avatar sizes, example:
define ( 'BP_AVATAR_FULL_WIDTH', 300 );
any avatars from activity/groups previously created will still use the old avatar size.
So if you set it to 300, and then I want to change it in the future to 100 and change the design/CSS, all the existing activity will still show 300 and look bad with the new CSS.

WordPress works this way to with image thumbnails, however, you can force a regeneration of them using a plugin.

In short, I am finding that BuddyPress is a great plugin but it seems to me that for the activity (the most important aspect of the plugin) you are stuck into using/showing it how the BuddyPress developers decided was the best format/look, because changing it via filters will result in headaches if I install my custom filters on a site with existing BuddyPress data.

If there were a way to regenerate the activity database to update everything with the filters/sizes set, that would solve most of the more obvious problems.

I do have the BuddyPress to WordPress profile syncing enabled. I did add the code above as you suggested, however it doesn’t list the correct profiles.

@jigesh hi
you should never remove $wpdb->prepare, is there for a reason 🙂
The reason why the plugin doesn’t work with wordpress 3.6, 3.7 and later, it’s clearly explained here: https://codex.wordpress.org/Class_Reference/wpdb
see where they wrote:
“Please note: As of 3.5, wpdb::prepare() enforces a minimum of 2 arguments.”
more details here:

PHP Warning: Missing argument 2 for wpdb::prepare()

and the plugin code provides just 1 parameter, generating a PHP warning.
Basically, the json returned doesn’t contain a valid json but contains the error message:
<br /><b>Warning</b>: Missing argument 2 for wpdb::prepare()
being not valid json, it can’t be rendered in the “Bubble”.
The correct solution is to keep $wpdb->prepare but change the query in order to pass “1” as second argument:
instead of
AND is_new = 1″
do:
AND is_new = %d”, 1
that’s because you *have* to pass a minimum of 2 arguments. So you have to re-factor the query in order to pass at least 1 second argument: first argument is the query, where you use placeholder %d (digit) instead of 1:
“SELECT * FROM {$bp->core->table_name_notifications} WHERE id IN {$list_ids} AND is_new = %d”
second argument is: 1
If you have to pass a string instead of a digit, you would use %s as placeholder.
regards
Andrea

@boonebgorges talks about some of the ugly and unscalable joins here

@synaptic

a fragment caching system

I totally agree with you, and would love to see fragment caching in BuddyPress (or more generally in WordPress)

That being said, if WordPress doesn’t include caching in core, it’s highly unlikely that BuddyPress would. If you created a ticket for this in Trac, it would probably quickly be closed as plugin territory.

The quickest way of getting this implemented would be to convince the author of FragmentCache or Fragment Cache or Redis cache to add support for BuddyPress.