Search Results for 'wordpress'
-
Search Results
-
@Andy Peatling – Very sad to be in hall of shame
1) Version 0.1.6 of BP Album+ that is posted on the WordPress plugin repository checks that BP is installed exactly as you have specified. Can you be a bit more specific about the defect?
2) I completely agree that current_user_can() is a better way to check for permissions in various plugin operations; and we will switch to the new function at the next BP Album+ release as per your request. In the meantime, why is using is_site_admin() so bad? Doesn’t current_user_can() just pass the call to is_site_admin() ?
/**
* Whether current user has capability or role.
*
* @since 2.0.0
*
* @param string $capability Capability or role name.
* @return bool
*/
function current_user_can( $capability ) {
$current_user = wp_get_current_user();
if( is_site_admin() ) <—- *NOTE*
return true;
if ( empty( $current_user ) )
return false;
$args = array_slice( func_get_args(), 1 );
$args = array_merge( array( $capability ), $args );
return call_user_func_array( array( &$current_user, ‘has_cap’ ), $args );
}
^F^
Regarding problems with the BuddyPress Links plugin…
Found the defect.
The problem is being caused by two blocks of code inside the BPLinks plugin that do not account for the situation where the BuddyPress administrator disables “friend” capabilities for the site.
When friend capabilities are disabled, calling the friends_check_friendship() function will crash the user thread. We handle this problem in BP Album+ by wrapping all calls to this function in a function_exists(‘friends_check_friendship’) statement, only calling the function if it is enabled.
This is a sneaky, subtle defect that could easily be missed during testing; fortunately, BPLink’s clean, well-documented source code made it easy to isolate and correct the problem.
Here’s a simple patch:
1) In “bp-links-classes.php” at line 650
REPLACE:
if ( $link_owner_user_id && $link_owner_user_id != $bp->loggedin_user->id && friends_check_friendship( $link_owner_user_id, $bp->loggedin_user->id ) ) {
$status_opts[] = self::STATUS_FRIENDS;
}
WITH:
if (function_exists(‘friends_check_friendship’)) {
if ( $link_owner_user_id && $link_owner_user_id != $bp->loggedin_user->id && friends_check_friendship( $link_owner_user_id, $bp->loggedin_user->id ) ) {
$status_opts[] = self::STATUS_FRIENDS;
}
}
2) In “bp-links-core.php” at line 1128
REPLACE:
return friends_check_friendship( $user_id, $link->user_id );
WITH:
if (function_exists(‘friends_check_friendship’))
return friends_check_friendship( $user_id, $link->user_id );
else
return null;
============================================================================
WordPress MU 2.9.2
BuddyPress Version 1.2.3
BuddyPress Links Version 0.3.2
BP Album+ 0.1.8 beta
^F^
